Skip to content

feat: Implement new notifications service (Push, dock badge and sounds) #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathanlab merged 6 commits into from
Feb 3, 2026
Merged

feat: Implement new notifications service (Push, dock badge and sounds) #728

jonathanlab merged 6 commits into from
Feb 3, 2026
+388 −92

Conversation

@charlesvien
Copy link
Contributor

@charlesvien charlesvien commented Jan 31, 2026 •
edited
Loading

A little 1 AM break from reliability to address something I have been seeing all week from hedge hogs, I triaged all our feedback in this channel on notifications + James PR from December:

Introduces a new NotificationService:

  • Fixes dock badge notifications not working reliably
  • Implements desktop popup notifications to notify the user when the agent completes their turn / has question/perms prompt / etc
  • Implements audio/sound notifications to notify the user when the agent completes their turn / has question/perms prompt / etc
    • Disabled by default, but can we get a more casual sound in as well?
Screenshot 2026-01-31 at 2 09 11 AM

@charlesvien charlesvien changed the title Implement new notifications service (Push, dock badge and sounds) feat: Implement new notifications service (Push, dock badge and sounds) Jan 31, 2026
@charlesvien charlesvien marked this pull request as ready for review January 31, 2026 09:43
@charlesvien charlesvien requested a review from a team as a code owner January 31, 2026 09:43
@charlesvien charlesvien mentioned this pull request Jan 31, 2026
Merged
@charlesvien Graphite App
Copy link
Contributor Author

charlesvien commented Jan 31, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@charlesvien charlesvien mentioned this pull request Jan 31, 2026
Merged
@charlesvien
Copy link
Contributor Author

charlesvien commented Jan 31, 2026

#236
#667
#710

@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from 35b3f64 to 6ac397b Compare January 31, 2026 10:16
@charlesvien charlesvien force-pushed the 01-31-revert_the_changes_that_made_the_execution_mode_viewer_a_dropdown branch from 6e37ed6 to 41974d8 Compare January 31, 2026 10:16
jonathanlab
jonathanlab approved these changes Jan 31, 2026
View reviewed changes
Copy link
Contributor

@jonathanlab jonathanlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg 🚢

@jonathanlab Graphite App
Copy link
Contributor

jonathanlab commented Jan 31, 2026 •
edited
Loading

Merge activity

  • Jan 31, 12:34 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 31, 1:26 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 31, 1:30 PM UTC: Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.
  • Feb 3, 12:04 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 3, 12:06 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 3, 12:11 PM UTC: @jonathanlab merged this pull request with Graphite.

@jonathanlab jonathanlab changed the base branch from 01-31-revert_the_changes_that_made_the_execution_mode_viewer_a_dropdown to graphite-base/728 January 31, 2026 13:17
@jonathanlab jonathanlab changed the base branch from graphite-base/728 to main January 31, 2026 13:24
@jonathanlab jonathanlab force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from f470697 to 6367b0c Compare January 31, 2026 13:25
@charlesvien charlesvien changed the base branch from main to graphite-base/728 January 31, 2026 21:54
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from 5e6f371 to f0ea1d6 Compare January 31, 2026 21:54
@charlesvien charlesvien changed the base branch from graphite-base/728 to 01-31-force-kill_process_on_shutdown_timeout_to_prevent_hang January 31, 2026 21:54
@charlesvien charlesvien mentioned this pull request Jan 31, 2026
Merged
Base automatically changed from 01-31-force-kill_process_on_shutdown_timeout_to_prevent_hang to main January 31, 2026 22:55
An error occurred while trying to automatically change base from 01-31-force-kill_process_on_shutdown_timeout_to_prevent_hang to main January 31, 2026 22:55
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from f0ea1d6 to 8acd158 Compare February 3, 2026 02:17
@charlesvien charlesvien changed the base branch from main to graphite-base/728 February 3, 2026 02:17
@charlesvien charlesvien changed the base branch from graphite-base/728 to 02-02-implement_processtrackingservice February 3, 2026 02:17
This was referenced Feb 3, 2026
Merged
Merged
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from 8acd158 to f85f252 Compare February 3, 2026 02:18
@charlesvien charlesvien force-pushed the 02-02-implement_processtrackingservice branch 2 times, most recently from f72d62a to c57a72f Compare February 3, 2026 02:20
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch 2 times, most recently from 5f1cfac to 817d6b9 Compare February 3, 2026 02:35
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch 3 times, most recently from 11266e9 to 1fce5b7 Compare February 3, 2026 04:37
@charlesvien charlesvien force-pushed the 02-02-implement_processtrackingservice branch from 2065821 to 9e00589 Compare February 3, 2026 06:12
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from 1fce5b7 to d0c3acf Compare February 3, 2026 06:12
This was referenced Feb 3, 2026
Merged
Merged
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch 4 times, most recently from 7eb1efa to a6bcbed Compare February 3, 2026 08:36
@charlesvien charlesvien force-pushed the 02-02-implement_processtrackingservice branch from 3f3d606 to decbfce Compare February 3, 2026 09:53
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch 2 times, most recently from 4adbc50 to 8d9a084 Compare February 3, 2026 09:55
@charlesvien charlesvien force-pushed the 02-02-implement_processtrackingservice branch 2 times, most recently from f311cae to 332bfd7 Compare February 3, 2026 10:05
@charlesvien charlesvien force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from 8d9a084 to 96a0abe Compare February 3, 2026 10:05
@jonathanlab jonathanlab changed the base branch from 02-02-implement_processtrackingservice to graphite-base/728 February 3, 2026 12:04
@jonathanlab jonathanlab changed the base branch from graphite-base/728 to main February 3, 2026 12:04
@jonathanlab jonathanlab force-pushed the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch from 96a0abe to 75a2b69 Compare February 3, 2026 12:05
@jonathanlab jonathanlab merged commit 43a0901 into main Feb 3, 2026
13 checks passed
@jonathanlab jonathanlab deleted the 01-31-implement_new_notifications_service_push_dock_badge_and_sounds_ branch February 3, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanlab jonathanlab jonathanlab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charlesvien @jonathanlab